Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added markdown and refactor in evaluator #717

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

Montagon
Copy link
Contributor

This PR includes several changes:

  1. Refactored the SuiteBuilder.kt file:
  • Removed the file writing logic from the toHtml function. The function now returns an Html object instead of writing to a file.
  • Removed the htmlFilename parameter from the toHtml function. The suite name is now passed as a parameter to the Html.get function.
  • Added a toMarkdown function that returns a Markdown object.
  1. Moved the Html.kt file from the output package to the models package and refactored the class:
  • Changed Html from a regular class to a value class.
  • The get function now returns an Html object instead of a String.
  • Added a suiteName parameter to the get function.
  1. Added a new Markdown.kt file in the models package:
  • The Markdown class is a value class that holds a markdown-formatted string.
  • The get function in the companion object generates a markdown-formatted string from a SuiteResults object and a suite name.

@Montagon Montagon merged commit 6b36284 into main Apr 15, 2024
6 checks passed
@Montagon Montagon deleted the evaluator/markdown-exporter branch April 15, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants