Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More possibilities for contexts #73

Merged
merged 3 commits into from
May 17, 2023
Merged

More possibilities for contexts #73

merged 3 commits into from
May 17, 2023

Conversation

serras
Copy link
Contributor

@serras serras commented May 17, 2023

This PR adds a few more possibilities for contexts, which came up in a conversation with @raulraja. The idea is that we have two different modes to work with contexts:

  • to update the current one,
  • or to create a new scope with its own context, which inherits the previous one.

Pinging @raulraja @nomisRev

raulraja
raulraja approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 LGTM

@serras serras merged commit 3ac51b2 into main May 17, 2023
1 check passed
@serras serras deleted the as-extend-context branch May 17, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@serras @raulraja