Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI.contextScope resources #88

Merged
merged 2 commits into from
May 22, 2023
Merged

AI.contextScope resources #88

merged 2 commits into from
May 22, 2023

Conversation

nomisRev
Copy link
Contributor

Previously the store build by contextScope was scoped to the ResourceScope of the entire AI DSL, but it's only used within the block of contextScope. Similarly, all the resources created within the block would also live for the entire AIScope lifecycle.

This PR creates a nested resourceScope for contextScope such that all the resources created within the nested DSL are scoped to the nested DSL itself.

@xebia-functional/team-ai @serras

serras
serras approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@serras serras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes complete sense! Thanks @nomisRev for this improvement :)

@nomisRev nomisRev merged commit b24de6d into main May 22, 2023
1 check passed
@nomisRev nomisRev deleted the contextscope-resources branch May 22, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serras serras serras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nomisRev @serras