Play Store link & analytics events. #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the Play Store button along with the App Store button to link to the Android app. It fires Analytics events for clicks on each of the three buttons.
|
I'm alright with this as a short-term solution, although I prefer #30, but I agree that the visuals are not great. We should either move these to a dedicated page or have a consist style for all three buttons. |
jbnicolai
pushed a commit
that referenced
this pull request
Sep 11, 2014
Adds all functionality of #29 except for the <br>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the Play Store button along with the App Store button to link
to the Android app. It fires Analytics events for clicks on each of the three
buttons.
I'm less than thrilled about the three different buttons on the page, none of them
the same size, etc. I'm thinking about creating a separate page for the apps (which
can include the full-size screenshot Lammert did a while back, as well as one for
the Android app), but moving the App/Play -Store buttons off the home page may
not be the brightest idea. Your thoughts are welcome.