Changed Tile, set query begin date off end date if provided. #85
Conversation
|
the codacy/pr finding is not really an issue, the synthetic.xml always sets a value for numberOfDays. |
|
|
||
| if not xldeployServer: | ||
| raise Exception("XL Deploy server ID must be provided") | ||
|
|
||
| today = org.joda.time.DateTime() | ||
| #set the acceptable range of values for numberOfDays | ||
| day_range = range(1,91) |
There was a problem hiding this comment.
Shouldn't this 90 or 91 be a hidden property in the synthetic.xml?
So containing: hidden="true"
There was a problem hiding this comment.
I can do that, was confused as to if it just not throw error on the range or if you wanted it hidden. I can update to have hidden="true"
There was a problem hiding this comment.
I think you misunderstood. numberOfDays is the number the end user can enter.
maxRange would be an additional property that the admin can configure as a hidden property.
changed numberOfDays to a hidden property.
changed to hidden=true
|
|
||
| if not xldeployServer: | ||
| raise Exception("XL Deploy server ID must be provided") | ||
|
|
||
| today = org.joda.time.DateTime() | ||
| #set the acceptable range of values for numberOfDays | ||
| day_range = range(1,91) |
There was a problem hiding this comment.
I think you misunderstood. numberOfDays is the number the end user can enter.
maxRange would be an additional property that the admin can configure as a hidden property.
Updated to always set the XLD task query begin date minus X number of days. Also removed the exception for number of days being out of range 1-90 days. If a number larger than 90 is provided for number of days, the value is truncated to 90 days.