New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOVE-1113 Using composability on basic AKS/EKS/GKE cluster blueprints #94
Conversation
LOVE-1113 Updating basic aws/azure/gcp cluster to use composability LOVE-1113 Updated gcp/basic-gke-cluster to use composability LOVE-1113 Added aws/basic-eks-cluster LOVE-1113 Changed 'kubernetes-namespace' to a parameter
aws/basic-eks-cluster/blueprint.yaml
Outdated
value: ap-southeast-1 | ||
- label: Asia Pacific (Sydney) | ||
value: ap-southeast-2 | ||
- !expr "awsRegions('ecs')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can use ECS here as EKS regions are not the same as ECS AFAIK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have manually added the 13 regions that support EKS (https://aws.amazon.com/about-aws/global-infrastructure/regional-product-services/)
aws/basic-eks-cluster/blueprint.yaml
Outdated
- name: Prefix | ||
type: Input | ||
prompt: "Specify the application prefix (use the default if you're not sure):" | ||
default: aws-eks- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we expect -
at end of prefix, cant we just append that when using it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing Prefix
aws/basic-eks-cluster/blueprint.yaml
Outdated
type: Confirm | ||
prompt: "Do you want to provision Amazon Elastic File System?" | ||
default: false | ||
- name: Prefix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this prefix used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a throwback from Vincent-days. I think it can be removed
type: Select | ||
prompt: "Select the AWS region:" | ||
options: | ||
- !expr "awsRegions('ecs')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can use 'ecs' regions here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have manually added the 13 regions that support EKS (https://aws.amazon.com/about-aws/global-infrastructure/regional-product-services/)
- GCP GKE | ||
- Azure AKS | ||
|
||
- name: ClusterName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we just let the composed blueprints ask for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The multicloud-pipeline
blueprint needs this value in order to call the XLD resources from XLR
- name: Prefix | ||
value: azure-aks- | ||
type: Input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this needs to be prompted, can't it be hidden?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing Prefix
@@ -21,14 +21,19 @@ spec: | |||
prompt: "What is the version of the application that you want to deploy?" | |||
default: latest | |||
|
|||
- name: KubernetesResourcesFile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are not letting the user choose the yaml files, then what is the point of letting them choose application name and version here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added it back so users can provide their own file again
LOVE-1113 Updating basic aws/azure/gcp cluster to use composability
LOVE-1113 Updated gcp/basic-gke-cluster to use composability
LOVE-1113 Added aws/basic-eks-cluster
LOVE-1113 Changed 'kubernetes-namespace' to a parameter
Definition of Done
This is the definition of done for (new and modified) blueprints to be accepted into the central XebiaLabs blueprints repository.
Value
This section describes how to determine whether a blueprint has enough value to be included in the central XebiaLabs blueprints repository.
Technical
This section describes how to determine whether the blueprint has the right technical quality to be included in the central XebiaLabs blueprints repository.
development
branch.README.md
file at the root of the blueprint folder that describes the blueprint, using the README template in the.github
folder of this repository.xebialabs/USAGE.md
file which, at a minimum, explains how to use the blueprint after it is generated (like adding any missing steps, creating accounts, setting up Docker containers, applying the YAML usingxl
CLI, running release. etc.). N.B.: Do not use this document to describe how to instantiate the blueprint. It will only be available to the user after the blueprint has been instantiated.docker/docker-compose.yml
file so that it can be tested without having to manually install those products. Do not use this Docker Compose file to start XL Deploy, XL Release, Docker or Kubernetes.secret: true
in theblueprint.yaml
parameter definition for question that ask for sensitive information.xebialabs/.gitignore
,xebialabs/values.xlvals
andxebialabs/secrets.xlvals
and does not refer to them from the files section of theblueprint.yaml
file. These files will be generated when the blueprint is instantiated. To generate thexebialabs/values.xlvals
file, use thesaveInXlVals: true
directive in the parameters section of the blueprint. To generate thexebialabs/secrets.xlvals
file, use thesecret: true
directive .aws/sample-app-demo
,xld-environment.yaml
Review and testing
This section describes how to determine whether the blueprint has been reviewed and tested well enough to be included in the central XebiaLabs blueprints repository.
__test__
folder for each blueprint. Refer theCONTRIBUTING.md
file at the root of of this repository for more details.docker/docker-compose.yml
that is generated as part of it.