Fixed issue which caused provisioning of domain each time because of … #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…provisioning command mismatch
| @@ -86,7 +86,7 @@ | |||
| List<Filesystem> filesystemMappings, List<String> copySpec) { | |||
| super(libvirt, baseDomainName, ipLookupStrategy, networkName, startTimeout, bootDelay, filesystemMappings); | |||
| this.provisionUrl = checkNotNullOrEmpty(provisionUrl, "provisionUrl"); | |||
| this.provisionCmd = checkNotNullOrEmpty(provisionCmd, "provisionCmd"); | |||
| this.provisionCmd = checkNotNullOrEmpty(provisionCmd, "provisionCmd").trim(); | |||
There was a problem hiding this comment.
Shouldn't the trim be on the inside of the check?
There was a problem hiding this comment.
We trim once 'checkNotNullOrEmpty' check has passed, at this point we are sure that trim operation will not throw a null pointer exception.
There was a problem hiding this comment.
Ric's point is that a .trim() might actually make you end up with an empty string.
rklaren
pushed a commit
that referenced
this pull request
Feb 12, 2016
Fix detection of already provisioned domain when provision command ends in spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue which caused provisioning of domain each time because of provisioning command mismatch between provision command from overcast.conf and one returned by existing domain in kvm, the comparison failure is caused by trailing blank space on provision command in overcast.conf. Provisioning command on kvm is returned without a training space even if it exists on original command. This causes a comparison failure and provisioning of new image each time.