Fixed remote powershell permission denied with cygwin ssh. #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found a bug during running a remote powershell command that did Get-DnsServerZone and Add-DnsServerResourceRecord commands via cygwin ssh that returned permission denied. Created a test app with just sshj and found that sshj worked fine, and after stepping through the code, I found that it appeared that the startProcess commands would run on session 1 vs session 0, which should have been the SFTP connection session. Found if I moved the sharedSftpClient = connectSftp() to the getSharedSftpClient() instead of the connect the issue was resolved and the powershell seemed to work as expected and how it works under WinSSHD. Additionally it seems that you would not want to start two connections anyway, unless they were going to be used, if one does not use any of the file commands, but just executes a process the additional connection is not needed. I have tested using SFTP prior to and after startProcess and see no adverse affects to the move, yet it now seems to work as expected. This change was testing in the 4.2.1 release and the 4.3.1-snapshot with WinSSHD and CygwinSSH
|
Thank you for your PR! Regards, Vincent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bug during running a remote powershell command that did Get-DnsServerZone and Add-DnsServerResourceRecord commands via cygwin ssh
that returned permission denied. Created a test app with just sshj and found that sshj worked fine, and after stepping through the code,
I found that it appeared that the startProcess commands would run on session 1 vs session 0, which should
have been the SFTP connection session. Found if I moved the sharedSftpClient = connectSftp() to the getSharedSftpClient() instead of the
connect the issue was resolved and the powershell seemed to work as expected and how it works under WinSSHD.
Additionally it seems that you would not want to start two connections anyway, unless they were going to be used, if one does not use any of
the file commands, but just executes a process the additional connection is not needed.
I have tested using SFTP prior to and after startProcess and see no adverse affects to the move, yet it now seems to work as expected.
This change was testing in the 4.2.1 release and the 4.3.1-snapshot with WinSSHD and CygwinSSH