Inherits() uses go url.ResolveReference(), fixes relative $ref #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, feel free to ask me :) |
|
Any problems / questions / wishes? |
xeipuuv
added a commit
that referenced
this pull request
Aug 27, 2014
Inherits() uses go url.ResolveReference(), fixes relative $ref
|
great, thank you :) |
marwan-at-work
pushed a commit
to marwan-at-work/gojsonreference
that referenced
this pull request
Feb 2, 2021
Update basic example in README to reflect that GetFileJson() takes a path to a file, not a URI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses golang
url.ResolveReference()to implementInherits()logic. Manual implementations ofinheritsImplHttp()andinheritsImplFileno longer needed. All handled byurl.ResolveReference()out of the box.Simplified
parse()Added RFC3986 examples as tests.
https://github.com/janmentzel/gojsonschema tests still pass.