This repository has been archived by the owner on Jan 5, 2023. It is now read-only.
Fix build for Windows #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the package so it can be imported when used under Windows. The `syslog` package unfortunately is not supported under Windows. Hence we disable it if we detect it. Fixes the following error: ``` xlog.go:66:12: undefined: syslog.New xlog.go:66:23: undefined: syslog.LOG_DEBUG ```
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 84.65% 84.65%
=======================================
Files 51 51
Lines 8522 8522
=======================================
Hits 7214 7214
Misses 1059 1059
Partials 249 249 Continue to review full report at Codecov.
|
fatih
added a commit
to planetscale/cli
that referenced
this pull request
May 4, 2021
This PR fixes our broken release pipeline. After adding support for `pscale database dump`, it started to depend to a new package `github.com/xelabs/go-mysqlstack/xlog`. This package unfortunately imports `syslog`, which doesn't work under Windows. I opened a fix to upstream: xelabs/go-mysqlstack#10, but until that PR is merged, we should make sure we're not blocked on releasing new version of the CLI. Hence in this PR we change `go.mod` so it relies on my fork for now: https://github.com/fatih/go-mysqlstack/tree/fatih/fix-windows. We're going to remove the `replace` directive once the upstream PR is merged. closes: planetscale/surfaces#285
fatih
added a commit
to planetscale/cli
that referenced
this pull request
May 10, 2021
Our fix to upstream was merged: xelabs/go-mysqlstack#10. Let's use that instead of our fork.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the package so it can be imported when used under Windows.
The
syslogpackage unfortunately is not supported under Windows. Hencewe disable it if we detect it.
Fixes the following error: