Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML5 compatible Legacy module #56

Merged
merged 1 commit into from May 30, 2020
Merged

Add HTML5 compatible Legacy module #56

merged 1 commit into from May 30, 2020

Conversation

xemlock
Copy link
Owner

@xemlock xemlock commented May 30, 2020

Legacy and Tidy_Transitional modules provided by HTMLPurifier are not compatible with HTML5 elements. For example, <s> tag is not obsolete in HTML5, so it shouldn't be transformed to <span>. The same applies to <u> tag.

Also the definition of <font> element in HTMLPurifier's Legacy module is missing validation of size and face attributes. And it's transform to <span> provides invalid font-size values for relative values of the size attribute.

@xemlock xemlock mentioned this pull request May 30, 2020
@xemlock xemlock merged commit c46494c into master May 30, 2020
@xemlock xemlock deleted the html5-legacy branch May 30, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant