UX: Get windows product and build number properly #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GXTX
reviewed
Dec 25, 2022
mborgerson
reviewed
Jan 5, 2023
mborgerson
reviewed
Jan 13, 2023
antangelo
reviewed
Jan 18, 2023
antangelo
reviewed
Jun 6, 2023
ui/xemu-os-utils-windows.c
Outdated
| return NULL; | ||
|
|
||
| if (RegGetValueW(HKEY_LOCAL_MACHINE, L"SOFTWARE\\Microsoft\\Windows NT\\CurrentVersion", | ||
| L"ProductName", RRF_RT_REG_SZ, (LPVOID)NULL, &product_name, (LPDWORD)&product_size) != ERROR_SUCCESS) |
There was a problem hiding this comment.
nit: These should be aligned consistently
ui/xemu-os-utils-windows.c
Outdated
| L"CurrentVersion", RRF_RT_REG_SZ, (LPVOID)NULL, ¤t_version, (LPDWORD)&version_size) != ERROR_SUCCESS) | ||
| return NULL; | ||
|
|
||
| /* if version number is 6.3/10.0 (8.1/10/11), get the build number from the DisplayVersion Registry. |
There was a problem hiding this comment.
nit: Comments not indented correctly
ui/xemu-os-utils-windows.c
Outdated
| } | ||
|
|
|
@Fabxx I made some simplifications over here: https://github.com/xemu-project/xemu/tree/fix/win_os_info Would you mind taking a look and helping to test it? |
Sure, will do when i get home. Will let you know within the day |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of returning "windows", based on the kernel version, we obtain the product name and the build number displayed in
winvercommand.For modern systems the check is made on "10.0" value according to the windows NT kernel version list.
Screenshot (via wine, in this case wine uses "Software" instead of "SOFTWARE"):
Wine windows XP
Wine windows Vista
Wine windows 7
Wine windows 8
Wine windows 8.1
