Halo 2 skybox fix (& realtime lighting shadow casting in other games) #1644
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clamping depth value to 1 apparently fixes this issue.
|
Fantastic! And yeah, the see-through textures issue still exists as per #55 but this is quite a welcome fix. |
|
I noticed that this changes also restore dynamic shadows (tested on Conker and Halo CE). Some screenshots: Latest release: Clamping z to 1: |
polymetal0
changed the title
This change by itself restores skybox, but previous one also fixes realtime shadows in other games.
|
Ideally you'd test with https://github.com/abaire/nxdk_pgraph_tests |
|
Thanks! I don't expect these changes to make it to the main branch anyway, but I hope someone with more understanding of the project can get a better clue about where the issue might be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clamping depth value to 1 apparently fixes this. Skybox is also affected by the see through issue:
EDIT: In case you are caching shaders in disk, you will need to delete your shader cache file.