Skip to content

Commit

Permalink
xenstore: check formats of trace
Browse files Browse the repository at this point in the history
When passing format strings to the trace function, allow gcc to analyze
those and warn on issues.

Signed-off-by: Norbert Manthey <nmanthey@amazon.de>
Reviewed-by: Thomas Friebel <friebelt@amazon.de>
Reviewed-by: Julien Grall <jgrall@amazon.co.uk>
Reviewed-by: Juergen Gross <jgross@suse.com>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
  • Loading branch information
nmanthey authored and Julien Grall committed Mar 3, 2021
1 parent 5c4634f commit 4a27a67
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/xenstore/xenstored_core.h
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ int delay_request(struct connection *conn, struct buffered_data *in,
/* Tracing infrastructure. */
void trace_create(const void *data, const char *type);
void trace_destroy(const void *data, const char *type);
void trace(const char *fmt, ...);
void trace(const char *fmt, ...) __attribute__ ((format (printf, 1, 2)));
void dtrace_io(const struct connection *conn, const struct buffered_data *data, int out);
void reopen_log(void);
void close_log(void);
Expand Down

0 comments on commit 4a27a67

Please sign in to comment.