Skip to content

Commit

Permalink
tools/configure: make iPXE dependent on QEMU traditional
Browse files Browse the repository at this point in the history
iPXE is only used by QEMU traditional, so make it off by default
unless QEMU traditional is enabled.

Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Fixes: bcf77ce ('configure: modify default of building rombios')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
  • Loading branch information
royger authored and ijackson-citrix committed Nov 9, 2021
1 parent 7379f9e commit 9d9cd0c
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 19 deletions.
28 changes: 16 additions & 12 deletions tools/configure
Original file line number Diff line number Diff line change
Expand Up @@ -1504,8 +1504,8 @@ Optional Features:
--enable-qemu-traditional
Enable qemu traditional device model, (DEFAULT is
off)
--enable-ipxe Enable in-tree IPXE, (DEFAULT is on for x86,
otherwise off, see also --with-system-ipxe)
--enable-ipxe Enable in-tree IPXE, (DEFAULT is off, see also
--with-system-ipxe)
--enable-rombios Enable ROMBIOS, (DEFAULT is on if qemu-traditional
or ipxe is enabled, otherwise off)
--enable-systemd Enable systemd support (default is DISABLED)
Expand Down Expand Up @@ -4300,25 +4300,29 @@ else

fi

if test "x$enable_ipxe" = "xno"; then :
ipxe=n
else
ipxe=y
fi

# Check whether --enable-ipxe was given.
if test "${enable_ipxe+set}" = set; then :
enableval=$enable_ipxe;
else

case "$host_cpu" in
i[3456]86|x86_64)
enable_ipxe="yes";;
*) enable_ipxe="no";;
esac
if test "x$enable_qemu_traditional" = "xyes"; then :

enable_ipxe="yes"

else

enable_ipxe="no"

fi

fi

if test "x$enable_ipxe" = "xno"; then :
ipxe=n
else
ipxe=y
fi

# Check whether --with-system-ipxe was given.
if test "${with_system_ipxe+set}" = set; then :
Expand Down
14 changes: 7 additions & 7 deletions tools/configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,13 @@ AC_SUBST(qemu_traditional)

AC_ARG_ENABLE([ipxe],
AS_HELP_STRING([--enable-ipxe],
[Enable in-tree IPXE, (DEFAULT is on for x86,
otherwise off, see also --with-system-ipxe)]),,[
case "$host_cpu" in
i[[3456]]86|x86_64)
enable_ipxe="yes";;
*) enable_ipxe="no";;
esac
[Enable in-tree IPXE,
(DEFAULT is off, see also --with-system-ipxe)]),,[
AS_IF([test "x$enable_qemu_traditional" = "xyes"], [
enable_ipxe="yes"
], [
enable_ipxe="no"
])
])
AS_IF([test "x$enable_ipxe" = "xno"], [ipxe=n], [ipxe=y])
AC_ARG_WITH([system-ipxe],
Expand Down

0 comments on commit 9d9cd0c

Please sign in to comment.