Skip to content

Commit

Permalink
tools/x86: don't rebuild cpuid-autogen.h every time
Browse files Browse the repository at this point in the history
The first thing the "xen-dir" rule does is delete the entire xen/
subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a
result there's no original version for $(move-if-changed ...) to compare
against, and hence the file and all its consumers would get rebuilt
every time. Instead only find and delete all the symlinks.

Fixes: eddf955 ("libx86: generate cpuid-autogen.h in the libx86 include dir")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
  • Loading branch information
jbeulich committed Mar 15, 2021
1 parent 14b95b3 commit b401174
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/include/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ xen-foreign:
$(MAKE) -C xen-foreign

xen-dir:
@rm -rf xen acpi
mkdir -p xen/libelf acpi
find xen/ acpi/ -type l -exec rm '{}' +
ln -s $(XEN_ROOT)/xen/include/public/COPYING xen/
ln -s $(XEN_ROOT)/xen/include/public/*.h xen/
ln -s $(XEN_ROOT)/xen/include/public/*/ xen/
Expand Down

0 comments on commit b401174

Please sign in to comment.