Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate progress reporting which is useless in logs #42

Merged
merged 2 commits into from Feb 3, 2019
Merged

Eliminate progress reporting which is useless in logs #42

merged 2 commits into from Feb 3, 2019

Conversation

YSakhno
Copy link
Contributor

@YSakhno YSakhno commented Apr 20, 2016

Hello,

I've made this little change that sanitizes logs a little by filtering out information about progress during software/packages install. Without it logs are full of (Reading database ... 5%^M(Reading database ... 10%^M and so on stuff.

Yuri Sakhno.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 57.597% when pulling 87dd127 on YSakhno:no-progress-in-logs into b0177f0 on xen-tools:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 57.482% when pulling 230167d on YSakhno:no-progress-in-logs into b0177f0 on xen-tools:master.

@xtaran
Copy link
Member

xtaran commented Apr 20, 2016

Hrm, while I do see that progress reporting doesn't make sense in log files I strongly dislike the idea of having "quiet" logs. First need to check how quiet --quiet is.

@YSakhno
Copy link
Contributor Author

YSakhno commented Apr 20, 2016

Actually, I cannot see the difference with and without --quiet (did not check very thoroughly though).

And --quiet (of any level) is not enough to silence the 'Reading database' messages because those do not come from apt-get according to this: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/874409

@xtaran
Copy link
Member

xtaran commented Apr 20, 2016

I just went through dpkg's options and found none to silence it. The only one which might help here is --status-fd.

@YSakhno
Copy link
Contributor Author

YSakhno commented Apr 21, 2016

Well, yes. That's why the need for sed-filtering. If you are not comfortable with --quiet option, you may omit it, I am fine with that (since it seems to make no real difference whatsoever). Just be sure to keep sed-filtering in place.

@xtaran xtaran added the ready Ready for merging label Oct 21, 2016
@xtaran xtaran added improvement General improvement, not really a bug or bug fix, but still good to be fixed/included intent to merge Generally positive wrt. to merging, still needs a more closer review and maybe some minor fixups labels Dec 16, 2018
@xtaran xtaran added this to the 4.8 milestone Dec 16, 2018
@xtaran xtaran merged commit 230167d into xen-tools:master Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement General improvement, not really a bug or bug fix, but still good to be fixed/included intent to merge Generally positive wrt. to merging, still needs a more closer review and maybe some minor fixups ready Ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants