Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on PyYAML==5.1.2 breaks compatibility with awscli #38

Closed
jwarlander opened this issue Aug 12, 2019 · 3 comments
Closed

Dependency on PyYAML==5.1.2 breaks compatibility with awscli #38

jwarlander opened this issue Aug 12, 2019 · 3 comments

Comments

@jwarlander
Copy link

Currently it seems that awscli depends on PyYAML<=5.1 for Python 3, which means that trying to install aws-gate AND awscli in the same Python environment doesn't work without a manual override.

Perhaps aws-gate should have a relaxed dependency, like eg. PyYAML>=5.1,<5.2 or whatever makes sense for the actual features used?

NOTE: There is a PR for awscli to bump the PyYAML dependency (aws/aws-cli#4355), but it's not there now, and it's so far unclear if it will actually solve this, as right now the aim is 5.1.1, not 5.1.2.

@xen0l
Copy link
Owner

xen0l commented Aug 12, 2019

Hello @jwarlander, thanks for reporting this. I was playing around with dependabot and I thought it be working. I am fine with the proposed solution (PyYAML>=5.1,<5.2) as it will fix the issue for you. Do you think that you can create a PR?

BTW, what platform are you using? I am currently testing homebrew package for aws-gate, which will allow to install aws-gate via homebrew. However, I ran into some issues, which I am trying to work on.

@xen0l
Copy link
Owner

xen0l commented Aug 12, 2019

Issues fixed in 0.4.1.

@xen0l xen0l closed this as completed Aug 12, 2019
@jwarlander
Copy link
Author

Thanks for the quick fix!

I'm on Linux (Ubuntu). Would definitely be cool if there was a .deb package available, or even, say, a PPA on https://launchpad.net/ -- but I can appreciate if you don't feel the effort is warranted, since pip installations tend to work fairly well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants