Upgrading pyyaml<=5.1 to pyyaml<=5.1.1 #4355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2019
Surgo
reviewed
Aug 5, 2019
| @@ -9,6 +9,6 @@ requires-dist = | |||
| docutils>=0.10,<0.15 | |||
| rsa>=3.1.2,<=3.5.0 | |||
| PyYAML>=3.10,<=3.13; python_version=="2.6" | |||
| PyYAML>=3.10,<=5.1;python_version!="2.6" | |||
| PyYAML>=3.10,<=5.1.1;python_version!="2.6" | |||
There was a problem hiding this comment.
I use 5.1.2 now.
I think <5.2 is better. Maybe bump major version when including backward incompatible changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fixes: #4350 #4042 #4243
Description of changes:
PyYAML 5.1.1 released on June 6, 2019 is not compatible with the latest version of the CLI.
If you try to install PyYAML and the CLI is already installed, the following error returns: "PyYAML 5.1.1 which is incompatible." This is due to PIP trying to install the latest PyYAML version (5.1.1). Command used to install PyYAML is:
pip3 install --force-reinstall --no-cache-dir pyyaml
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.