Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALFREDAPI-531 fix facet qname splitting #184

Merged
merged 1 commit into from
Sep 10, 2023
Merged

ALFREDAPI-531 fix facet qname splitting #184

merged 1 commit into from
Sep 10, 2023

Conversation

hechmi-dammak-xenit
Copy link
Contributor

@hechmi-dammak-xenit hechmi-dammak-xenit commented Aug 31, 2023 •
edited by WimCrols
Loading

Fixes https://xenitsupport.jira.com/browse/ALFREDAPI-531

  • Is CHANGELOG.md extended?
  • Does this PR avoid breaking the API?
    Breaking changes include adding, changing or removing endpoints and/or JSON objects used in requests and responses.
  • Does the PR comply to REST HTTP result codes policy outlined in the user guide?
  • Is error handling done through a method annotated with @ExceptionHandler in the webscript classes?
  • Does the PR follow our coding styleguide and other active procedures?
  • Is usage of this. prefix avoided?

See README.md for full explanation.

WimCrols
WimCrols approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@WimCrols WimCrols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SearchFacetsServiceImpl.java can use another reformat, but it's not blocking so: :shipit:

@todorinskiz todorinskiz merged commit 4766eb4 into master Sep 10, 2023
10 checks passed
@todorinskiz todorinskiz deleted the ALFREDAPI-531 branch September 10, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todorinskiz todorinskiz todorinskiz approved these changes

@WimCrols WimCrols WimCrols approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hechmi-dammak-xenit @todorinskiz @WimCrols