ALFREDOPS-604 Adding metrics for solr tracking and sharding #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijslemmens
force-pushed
the
ALFREDOPS-604
branch
2 times, most recently
from
b8d20d2
to
096561d
Compare
kerkhofsd
suggested changes
Sep 9, 2020
...n/java/eu/xenit/alfred/telemetry/alfrescointegration/MetricsControllerBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
...atform/src/main/java/eu/xenit/alfred/telemetry/binder/solr/SolrMetricsBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
...atform/src/main/java/eu/xenit/alfred/telemetry/binder/solr/SolrMetricsBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
...atform/src/main/java/eu/xenit/alfred/telemetry/binder/solr/SolrMetricsBeanPostProcessor.java
Show resolved
Hide resolved
...atform/src/main/java/eu/xenit/alfred/telemetry/binder/solr/tracking/SolrTrackingMetrics.java
Outdated
Show resolved
Hide resolved
...form/src/main/resources/alfresco/module/alfred-telemetry-platform/alfresco-global.properties
Outdated
Show resolved
Hide resolved
thijslemmens
force-pushed
the
ALFREDOPS-604
branch
from
096561d
to
a2a86f6
Compare
thijslemmens
force-pushed
the
ALFREDOPS-604
branch
from
cf02f65
to
0e30b48
Compare
kerkhofsd
previously approved these changes
Sep 9, 2020
todorinskiz
previously approved these changes
Sep 10, 2020
tgeens
reviewed
Sep 10, 2020
...rm/src/test/java/eu/xenit/alfred/telemetry/binder/solr/sharding/SolrShardingMetricsTest.java
Outdated
Show resolved
Hide resolved
tgeens
reviewed
Sep 10, 2020
...atform/src/main/java/eu/xenit/alfred/telemetry/binder/solr/sharding/SolrShardingMetrics.java
Outdated
Show resolved
Hide resolved
thijslemmens
dismissed stale reviews from todorinskiz and kerkhofsd
via
9ced590
tgeens
previously approved these changes
Sep 10, 2020
thijslemmens
force-pushed
the
ALFREDOPS-604
branch
from
eec78b5
to
dfdf2e4
Compare
tgeens
approved these changes
Sep 10, 2020
tgeens
reviewed
Nov 4, 2020
|
|
||
| public void refresh() { | ||
| long now = System.currentTimeMillis(); | ||
| if (rawData == null || now - lastRefresh > ttl) { |
There was a problem hiding this comment.
where is lastRefresh updated ?
tgeens
reviewed
Nov 4, 2020
| Collectors.toSet()); | ||
| } | ||
|
|
||
| public ShardState getShardState(ShardInstance shardInstance) { |
There was a problem hiding this comment.
See #36
Should this be converted this to Optional<ShardState> ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added metrics that make it possible to monitor a sharded Solr setup