Move etag header tests to separate test file #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsCW
force-pushed
the
optimistic-locking
branch
from
1afff17
to
f24d67b
Compare
tgeens
reviewed
Apr 3, 2024
...ing-data-rest/src/test/java/com/contentgrid/spring/data/rest/etag/OptimisticLockingTest.java
Show resolved
Hide resolved
NielsCW
force-pushed
the
optimistic-locking
branch
from
69a228d
to
c80350e
Compare
tgeens
reviewed
Apr 3, 2024
| .andExpect(headers().etag().exists()); | ||
| } | ||
|
|
||
| void checkETagUnchanged(String url, int original) throws Exception { |
There was a problem hiding this comment.
I would also change the type in these arguments:
Suggested change
| void checkETagUnchanged(String url, int original) throws Exception { | |
| void checkETagUnchanged(String url, String etag) throws Exception { |
tgeens
reviewed
Apr 3, 2024
...d-spring-data-rest/src/test/java/com/contentgrid/spring/test/matchers/ETagHeaderMatcher.java
Outdated
Show resolved
Hide resolved
NielsCW
force-pushed
the
optimistic-locking
branch
from
c578645
to
5fba7c5
Compare
tgeens
approved these changes
Apr 4, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move optimistic locking tests about
If-MatchandETagheaders fromInvoicingApplicationTestto a new file