Fix memleak on GraphicsDevce.DirectD3.Begin() #427
Conversation
.Begin() method keep new creating SharpDX.DirectD3D11.Query object after every frame and created objects do not get freed.
|
|
| { | ||
| var disjointQueryDiscription = new QueryDescription { Type = SharpDX.Direct3D11.QueryType.TimestampDisjoint }; | ||
| currentDisjointQuery = new Query(NativeDevice, disjointQueryDiscription); | ||
| } | ||
|
|
||
| disjointQueries.Enqueue(currentDisjointQuery); | ||
| // Try to read back the oldest disjoint query and reuse it. If not ready, create a new one. | ||
| if (NativeDeviceContext.GetData(currentDisjointQuery, out QueryDataTimestampDisjoint result)) |
There was a problem hiding this comment.
Thanks for initial investigation about this memory leak.
Data is supposed to come back asynchronously, typically a few frame later.
As a result, this GetData calls probably always return false if we keep reusing a single one.
This is the reason we need a pool of them. It shouldn't grow much more than 2/3 objects (GPU is behind a few frames, but not much more usually).
Is this the place that keeps allocating regularly?
We need to find out why it keeps allocating them rather than always reusing a pool of 2/3.
There was a problem hiding this comment.
Thanks for engaging in this issue. Could you take a loot at #428?
This memleak was found when I'm trying to fix low performance issue with Xenko.
|
I investigated and found the root reason. |
PR Details
Fix memleak on GraphicsDevce.DirectD3.Begin()
GraphicsDevce.DirectD3.Begin()method keep new creatingSharpDX.DirectD3D11.Queryobject afterevery frame and created objects do not get freed.
Description
Related Issue
Motivation and Context
Types of changes
Checklist