Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Slurm 19 support #670

Merged
merged 22 commits into from
Mar 20, 2020
Merged

Adds Slurm 19 support #670

merged 22 commits into from
Mar 20, 2020

Conversation

sverhoeven
Copy link
Member

Fixes #669

@codecov-io
Copy link

codecov-io commented Mar 20, 2020

Codecov Report

Merging #670 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #670      +/-   ##
============================================
- Coverage     86.86%   86.65%   -0.22%     
+ Complexity     1831     1830       -1     
============================================
  Files           112      112              
  Lines          5161     5214      +53     
  Branches        768      779      +11     
============================================
+ Hits           4483     4518      +35     
- Misses          462      472      +10     
- Partials        216      224       +8     
Flag Coverage Δ Complexity Δ
#fixedclientenvironment 26.04% <ø> (-0.23%) 489.00 <ø> (ø)
#integration 57.42% <ø> (+0.18%) 1022.00 <ø> (+2.00)
#livelocal 20.73% <ø> (+1.12%) 389.00 <ø> (+24.00)
#unit 61.29% <ø> (-0.11%) 1428.00 <ø> (-1.00)
Impacted Files Coverage Δ Complexity Δ
...ter/xenon/adaptors/schedulers/ScriptingParser.java 85.35% <0.00%> (-7.76%) 49.00% <0.00%> (-2.00%)
...enon/adaptors/schedulers/slurm/SlurmScheduler.java 76.92% <0.00%> (-0.48%) 36.00% <0.00%> (ø%)
...iencecenter/xenon/adaptors/shared/ssh/SSHUtil.java 76.21% <0.00%> (+0.25%) 35.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0972eae...e3f2c89. Read the comment docs.

@jmaassen jmaassen marked this pull request as ready for review March 20, 2020 12:40
@jmaassen jmaassen self-requested a review March 20, 2020 12:41
Copy link
Member

@jmaassen jmaassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic code. Almost made me cry ;-)

@jmaassen jmaassen merged commit 8457939 into master Mar 20, 2020
@jmaassen jmaassen deleted the jobstatus-bug branch March 20, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for slurm 19
3 participants