Workaround for class loading deadlocks caused by ThrowableProxyHelper

xenondevs · Apr 5, 2024 · bd4385f · bd4385f
1 parent 5ef03c5
commit bd4385f
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/nova/src/main/kotlin/xyz/xenondevs/nova/transformer/PatchedClassLoader.kt b/nova/src/main/kotlin/xyz/xenondevs/nova/transformer/PatchedClassLoader.kt
@@ -64,6 +64,11 @@ internal class PatchedClassLoader : ClassLoader(PAPER_CLASS_LOADER.parent) {
             // if yes, this indicates a recursive call (PatchedClassLoader) or a call that will become recursive (NovaClassLoader)
             if (className == "xyz.xenondevs.nova.loader.NovaClassLoader" || className == "xyz.xenondevs.nova.transformer.PatchedClassLoader")
                 return false
+
+            // does not indicate a recursive call, but is the most common class loading deadlock cause,
+            // so it is included here until the root cause is resolved (removal of PatchedClassLoader)
+            if (className == "org.apache.logging.log4j.core.impl.ThrowableProxyHelper")
+                return false
         }
 
         return true