Update sqlcipher to 4.3.0. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade amalgamation code
upgrade amalgamation code
Fix type of variadic
improve FAQ re: in-memory databases
Fix typo in readme
Added TestOpenContext Added TestFileCopyTruncate Added ping to doTestOpen
Updated Ping and doTestOpen. Added TestOpenContext and TestFileCopyTruncate
docs: fix typo
upgrade amalgamation code
When building on darwin with the `libsqlite3` tag, go-sqlite3 adds the homebrew library path. It does not, however, add the homebrew include path, which means that the MacOS sqlite3 header is used instead. On my system, this results in build errors that look like this: ./sqlite3_load_extension.go:25:8: could not determine kind of name for C.sqlite3_enable_load_extension ./sqlite3_load_extension.go:33:8: could not determine kind of name for C.sqlite3_load_extension Add the homebrew include path as well, so that he header matches the libraries we're using. Signed-off-by: George Dunlap <george.dunlap@citrix.com>
Issue #651: Fix of typo
darwin/libsqlite3: Also use the homebrew include path
Fixes: #724
Fixes: #733
[why] Context cancellation goroutine is not in sync with Next() method lifetime. It leads to sql.ErrNoRows instead of context.Canceled often (easy to reproduce). It leads to interruption of next query executed on same connection (harder to reproduce). [how] Do query in goroutine, wait when interruption done. [testing] Add unit test that reproduces error cases.
[why] see mattn/go-sqlite3#607 SQLite default journal mode is DELETE, but forcing it on open causes "database is locked" if other connection exists with WAL mode, for example. [how] Don't set DELETE mode if not set in DSN explicitly. [testing] Run tests in my project where WAL mode is used.
Fix Open() journal mode regression
Add Go 1.12.x/1.13.x to CI
Activating Open Collective
Improve readability of Backup()
Add build constraints for non cgo
upgrade amalgamation code
Fix context cancellation racy handling
* adding SystemErrno to Error, and fixing error logic when open fails * fix for old versions of libsqlite3 that do not have sqlite3_system_errno defined * fixing pre-processor logic
* feat: add go modules * feat: upgrade goquery dependency
* report actual error message if sqlite3_load_extension fails * more fixes and test cases Co-authored-by: Jesse Rittner <jrittner@lutron.com>
Once the regex encountered the first instance of a non-match, it would return without processing the rest of the rows in the statement. This change allows it to process the remaining, only setting the sqlite3_result_int to zero then continuing. This worked fine for the example as it only had one item to process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.