Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagating changes to "sonatypePublishTo" and "publishTo" to subprojects. #77

Merged
merged 1 commit into from Jan 11, 2019

Conversation

atooni
Copy link
Contributor

@atooni atooni commented Sep 22, 2018

This fixes #76

@xerial xerial self-requested a review September 23, 2018 09:09
@xerial
Copy link
Owner

xerial commented Sep 23, 2018

@atooni Thanks for the PR.

It looks good to me, except the fix is not working for sbt 0.13.x.
Now that we don’t need to support sbt 0.13.x we can drop the support for 0.13.x to pass this PR.

Did you test this fix on your project?

@atooni
Copy link
Contributor Author

atooni commented Sep 23, 2018

@xerial I noticed travis failing. I think this is because I used the new slash syntax for my changes. I am late to the game of sbt and have only briefly looked at it before. We have just migrated to sbt and have used 1.2.3, so I canẗ really speak for 0.13.x.

If you are happy to drop 0.13.x support for future releases, for me that is perfectly fine. On my own project the fix seems to work as expected and I am able to publish all my aggregates to sonatype with it.

For reference: Our project lives in https://github.com/woq-blended/blended; I am just trying to get auto releases via travis working for me.

@xerial
Copy link
Owner

xerial commented Jan 11, 2019

Let me merge this first, then I will drop sbt 0.13 support

@xerial xerial merged commit 68b3fc8 into xerial:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propagate changes to publishTo and sonatypePublishTo tu subprojects
2 participants