-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed date/time handling #110
Open
agalanin
wants to merge
4
commits into
xerial:master
Choose a base branch
from
agalanin:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,150 @@ | ||
package org.sqlite; | ||
|
||
import static org.junit.Assert.*; | ||
|
||
import java.io.ByteArrayInputStream; | ||
import java.io.UnsupportedEncodingException; | ||
import java.sql.Connection; | ||
import java.sql.Date; | ||
import java.sql.DriverManager; | ||
import java.sql.PreparedStatement; | ||
import java.sql.ResultSet; | ||
import java.sql.ResultSetMetaData; | ||
import java.sql.SQLException; | ||
import java.sql.Statement; | ||
import java.util.StringTokenizer; | ||
|
||
import org.junit.After; | ||
import org.junit.Before; | ||
import org.junit.BeforeClass; | ||
import org.junit.Test; | ||
|
||
/* | ||
* Created by Alexander Galanin <al@galanin.nnov.ru> | ||
*/ | ||
|
||
public class DateTimeTest | ||
{ | ||
// Mon May 23 06:06:21.123 MSK 2016 = Mon May 23 03:06:21.123 GMT 2016 | ||
private static final long DATETIME_UNIX = 1463972781L; | ||
private static final long DATETIME_MILLISECONDS = 123; | ||
private static final long DATETIME_UNIX_HIPRECISION = DATETIME_UNIX * 1000 + DATETIME_MILLISECONDS; | ||
private static final Date DATETIME = new Date(DATETIME_UNIX * 1000); | ||
private static final Date DATETIME_HIPRECISION = new Date(DATETIME_UNIX_HIPRECISION); | ||
|
||
private Connection conn; | ||
private PreparedStatement stat; | ||
|
||
@After | ||
public void close() throws SQLException { | ||
stat.close(); | ||
conn.close(); | ||
} | ||
|
||
@Test | ||
public void setDateUnix() throws SQLException { | ||
SQLiteConfig config = new SQLiteConfig(); | ||
|
||
config.setReadOnly(true); | ||
config.setDateClass("INTEGER"); | ||
config.setDatePrecision("SECONDS"); | ||
|
||
conn = DriverManager.getConnection("jdbc:sqlite:", config.toProperties()); | ||
stat = conn.prepareStatement("select strftime('%s', ?, 'unixepoch')"); | ||
stat.setDate(1, DATETIME); | ||
|
||
ResultSet rs = stat.executeQuery(); | ||
assertTrue(rs.next()); | ||
assertEquals(rs.getLong(1), DATETIME_UNIX); | ||
rs.close(); | ||
} | ||
|
||
@Test | ||
public void setDateJulian() throws SQLException { | ||
SQLiteConfig config = new SQLiteConfig(); | ||
|
||
config.setReadOnly(true); | ||
config.setDateClass("REAL"); | ||
|
||
conn = DriverManager.getConnection("jdbc:sqlite:", config.toProperties()); | ||
stat = conn.prepareStatement("select strftime('%s', ?)"); | ||
stat.setDate(1, DATETIME); | ||
|
||
ResultSet rs = stat.executeQuery(); | ||
assertTrue(rs.next()); | ||
assertEquals(rs.getLong(1), DATETIME_UNIX); | ||
rs.close(); | ||
} | ||
|
||
/** | ||
* Driver MUST format date/time in UTC because SQLite's internal date/time format is UTC. | ||
* | ||
* To test this in UTC timezone use java.util.TimeZone.setDefault(java.util.TimeZone.getTimeZone("GMT+3")); | ||
*/ | ||
@Test | ||
public void setDateText() throws SQLException { | ||
SQLiteConfig config = new SQLiteConfig(); | ||
|
||
config.setReadOnly(true); | ||
config.setDateClass("TEXT"); | ||
|
||
conn = DriverManager.getConnection("jdbc:sqlite:", config.toProperties()); | ||
stat = conn.prepareStatement("select strftime('%s', ?)"); | ||
stat.setDate(1, DATETIME); | ||
|
||
ResultSet rs = stat.executeQuery(); | ||
assertTrue(rs.next()); | ||
assertEquals(rs.getLong(1), DATETIME_UNIX); | ||
rs.close(); | ||
} | ||
|
||
@Test | ||
public void getDateInt() throws SQLException { | ||
SQLiteConfig config = new SQLiteConfig(); | ||
|
||
config.setReadOnly(true); | ||
config.setDateClass("INTEGER"); | ||
config.setDatePrecision("SECONDS"); | ||
|
||
conn = DriverManager.getConnection("jdbc:sqlite:", config.toProperties()); | ||
stat = conn.prepareStatement("select " + String.valueOf(DATETIME_UNIX)); | ||
|
||
ResultSet rs = stat.executeQuery(); | ||
assertTrue(rs.next()); | ||
assertEquals(rs.getDate(1), DATETIME); | ||
rs.close(); | ||
} | ||
|
||
/** | ||
* Driver MUST scan date/time in UTC because SQLite's internal date/time format is UTC. | ||
* | ||
* To test this in UTC timezone use java.util.TimeZone.setDefault(java.util.TimeZone.getTimeZone("GMT+3")); | ||
*/ | ||
@Test | ||
public void getDateJulian() throws SQLException { | ||
conn = DriverManager.getConnection("jdbc:sqlite:"); | ||
stat = conn.prepareStatement("select julianday(" + String.valueOf(DATETIME_UNIX) + ", 'unixepoch', '+' || (" + String.valueOf(DATETIME_MILLISECONDS) + " / 1000.0) || ' seconds')"); | ||
|
||
ResultSet rs = stat.executeQuery(); | ||
assertTrue(rs.next()); | ||
assertEquals(rs.getDate(1), DATETIME_HIPRECISION); | ||
rs.close(); | ||
} | ||
|
||
/** | ||
* Driver MUST scan date/time in UTC because SQLite's internal date/time format is UTC. | ||
* | ||
* To test this in UTC timezone use java.util.TimeZone.setDefault(java.util.TimeZone.getTimeZone("GMT+3")); | ||
*/ | ||
@Test | ||
public void getDateString() throws SQLException { | ||
conn = DriverManager.getConnection("jdbc:sqlite:"); | ||
stat = conn.prepareStatement("select strftime('%Y-%m-%d %H:%M:%f', " + String.valueOf(DATETIME_UNIX) + ", 'unixepoch', '+' || (" + String.valueOf(DATETIME_MILLISECONDS) + " / 1000.0) || ' seconds')"); | ||
|
||
ResultSet rs = stat.executeQuery(); | ||
assertTrue(rs.next()); | ||
assertEquals(rs.getDate(1), DATETIME_HIPRECISION); | ||
rs.close(); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this moves the driver away from the JDBC spec by ignoring the user supplied Calendar/Timezone information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately there are no sqlite datatype like 'timestamp with timezone' in postgresql, so timezone information is lost during saving in sqlite database.