Add additional crypto methods to PublicKey. #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: `tweak_add` will NOT work without secp256k1. We shall add pure-python implementation for such cases.
6 tasks
Codecov Report
@@ Coverage Diff @@
## develop #66 +/- ##
===========================================
- Coverage 58.41% 56.28% -2.14%
===========================================
Files 19 19
Lines 1171 1226 +55
===========================================
+ Hits 684 690 +6
- Misses 487 536 +49
Continue to review full report at Codecov.
|
xeroc
added a commit
that referenced
this pull request
Jul 11, 2018
Release 0.6.3 28c5796 (HEAD -> master) Merge branch 'release/0.6.3' 1a03fb0 (release/0.6.3) Updated docs 463cf18 Cleanup and linting 13966bf version bump 0b5ce1b (origin/develop, develop) Allow num_retries to be smaller than zero e9af291 allow to obtain chain_parameters 5ef1830 properly use register_apis and api_id a176d61 Fix legacy 8033e92 entirely new structure for API calls f3ac669 Merge pull request #66 from jhtitor/pubkey_tweak 78ae5f9 version bump b54a128 Allow more flexibility when defining the chain 3ee502c Add additional crypto methods to PublicKey. 8f3a6bd Improve retrying of other nodes eeef51e Add additional crypto methods to PrivateKey. (#64)
|
@jhtitor Is it possible that you provide unit tests for those? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
tweak_addwill NOT work without secp256k1. We shall add pure-python implementation for such cases.