Swtich to embedded TLS roots instead of Native TLS #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mac Native TLS takes a long time to load. rustls/rustls-native-certs#30 This is an issue as some git operations spawn (sequentially) a large number of git-xet subprocesses. This switches reqwest to using an embedded Mozilla certificate roots. (webpki-roots crate)
|
Could this be made optional? Embedding root certificates (even for internal use) is a big no-no for some Linux distributions. I package this for Arch Linux for example which has a policy against it. Since the problem is macOS specific could the option to eschew the system certificates at least be made platform specific? If this isn't a problem on Linux but the "solution" is a problem in its own right, this is a step backwards. |
|
#195 amends this to use embedded root certs only on MacOS. |
|
Thanks for that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac Native TLS takes a long time to load.
rustls/rustls-native-certs#30
This is an issue as some git operations spawn (sequentially) a large number of git-xet subprocesses. This switches reqwest to using an embedded Mozilla certificate roots. (webpki-roots crate). This reduces push time by about 33%.