Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a common interface for JedisCommands and JedisClusterCommands #1931

Closed
ptahchiev opened this issue Jan 10, 2019 · 6 comments
Closed

Add a common interface for JedisCommands and JedisClusterCommands #1931

ptahchiev opened this issue Jan 10, 2019 · 6 comments
Milestone

Comments

@ptahchiev
Copy link

ptahchiev commented Jan 10, 2019

Hey guys,
i'm having some trouble migrating this project:
https://github.com/jlinn/quartz-redis-jobstore
to jedis 3.0.x

So in the previous (2.9.x) version the JedisCluster was implementing JedisCommands and in 3.0.x it now implements a different interface JedisClusterCommands which has most of the JedisCommands methods in. Can we have all the common methods extracted to a common interface to both JedisClusterCommands and JedisCommands?

Something like:

           TOP_INTF
     /               \
JedisCommands    JedisClusterCommands
@marcosnils
Copy link
Contributor

I don't see why we cannot unify interfaces to avoid duplication. WDYT @gkorland / @sazzad16 ?

@ptahchiev
Copy link
Author

Here is a PR: #1932

@ptahchiev
Copy link
Author

Any update on this?

@ptahchiev
Copy link
Author

Any update here? It blocks me to update to the latest spring-boot :(

@TristanPerry
Copy link

Another 👍 for this issue/PR - it would be quite useful to have.

@sazzad16
Copy link
Collaborator

sazzad16 commented Dec 8, 2021

Resolved by #2693

@sazzad16 sazzad16 closed this as completed Dec 8, 2021
@sazzad16 sazzad16 added this to the 4.0.0 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants