Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve javadocs #978

Open
marcosnils opened this issue May 6, 2015 · 11 comments
Open

Improve javadocs #978

marcosnils opened this issue May 6, 2015 · 11 comments

Comments

@marcosnils
Copy link
Contributor

Javadocs are mainly a copy/paste of the redis documentation. We need to change them to represent proper java types and exception handling.

There are also methods which doesn't have any javadoc at all.

@nrktkt
Copy link
Contributor

nrktkt commented Aug 4, 2015

Just ran into #976 as well and finding the docs lacking.
Whats the status on this issue?

@marcosnils
Copy link
Contributor Author

@kag0 we're working on some important core features of Jedis at this moment and we're only two active collaborators. Any help would be much appreciated 😄

@HeartSaVioR
Copy link
Contributor

I thought about Javadoc a little.

As Marcos said, we're only two active collaborators.
I'm wondering we could perfectly maintain source codes with javadoc. It was already nearly unmaintained, and I think it can't be changed unless we have many active contributors or collaborators.

Btw, we can move javadoc from implementations to interfaces, and use @inheritdoc tag to reduce amount of duplicated comments.
@marcosnils What do you think?

@marcosnils
Copy link
Contributor Author

@HeartSaVioR moving Javadocs to interfaces seems the right way to go. I don't have time to do that kind of work at this moment, hopefully some new collaborator would help :)

@HeartSaVioR
Copy link
Contributor

OK. I also think we may just replace the explanations for the command to link to Redis doc, since it is actively maintained with many contributors.

@marcosnils
Copy link
Contributor Author

If we replace javadocs with redis links then users without internet connection won't be able to see the docs (which is kind of sad). Redis docs are stored in a JSON format in the redis page repo.

Maybe we can annotate the javadocs in some way which allows us to run a simple program which takes the commands description form the redis json doc and replaces it into Jedis. I'm not sure about this exactly but I agree with you that maintaining the documentation is quite messy as we don't have the enough collaborators to do it ATM.

@nrktkt
Copy link
Contributor

nrktkt commented Aug 6, 2015

javadocs support html in the comments, so you could potentially do something there with the redis docs. Wouldn't fix issues like #976 though.
I wouldn't be opposed to helping to get some native docs in place, I just don't know when I'd have time. At bare minimum it shouldn't be hard to get default javadocs up on gh-pages as a starter.

@marcosnils
Copy link
Contributor Author

@kag0 👍

@nrktkt
Copy link
Contributor

nrktkt commented Aug 7, 2015

@marcosnils will you please create a gh-pages branch (off of master) so I can open a PR into it?

@HeartSaVioR
Copy link
Contributor

@kag0 Done.

smukil added a commit to smukil/dyno-queues that referenced this issue Oct 2, 2019
The Jedis docs for each command are just a copy paste of Redis docs
which doesn't translate well to Java.
redis/jedis#978

From some stack overflow googling, we see the right way to use
zrank(), and this patch changes the code to comply with that.
smukil added a commit to Netflix/dyno-queues that referenced this issue Oct 2, 2019
The Jedis docs for each command are just a copy paste of Redis docs
which doesn't translate well to Java.
redis/jedis#978

From some stack overflow googling, we see the right way to use
zrank(), and this patch changes the code to comply with that.
Copy link

This issue is marked stale. It will be closed in 30 days if it is not updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants