Not extend Junit Assert classes in Tests. #1316 #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -110,7 +115,10 @@ public void multiBulkReply() { | |||
| expected.add(SafeEncoder.encode("Hello")); | |||
| expected.add(SafeEncoder.encode("World")); | |||
|
|
|||
| assertEquals(expected, response); | |||
| assertEquals(expected.size(), response.size()); | |||
There was a problem hiding this comment.
We can apply assertByteArrayListEquals this case, right?
There was a problem hiding this comment.
Yes. Thats right. But I want to use it without extending. Let me look into it.
|
Thanks for the work. LGTM. Extending Assert was old fashion and this pull request corrects it. @marcosnils Please review and merge. Thanks! |
|
👍 LGTM!. thx for the contribution @smadasu |
marcosnils
pushed a commit
that referenced
this pull request
Jul 3, 2016
* Not extend Junit Assert classes in Tests. #1316 Conflicts: src/test/java/redis/clients/jedis/tests/ModuleTest.java src/test/java/redis/clients/jedis/tests/PipeliningTest.java src/test/java/redis/clients/jedis/tests/commands/AllKindOfValuesCommandsTest.java src/test/java/redis/clients/jedis/tests/commands/BinaryValuesCommandsTest.java src/test/java/redis/clients/jedis/tests/commands/HashesCommandsTest.java src/test/java/redis/clients/jedis/tests/commands/ScriptingCommandsTest.java src/test/java/redis/clients/jedis/tests/commands/SetCommandsTest.java
marcosnils
pushed a commit
that referenced
this pull request
Jul 3, 2016
* Not extend Junit Assert classes in Tests. #1316 Conflicts: src/test/java/redis/clients/jedis/tests/ModuleTest.java src/test/java/redis/clients/jedis/tests/PipeliningTest.java src/test/java/redis/clients/jedis/tests/commands/AllKindOfValuesCommandsTest.java src/test/java/redis/clients/jedis/tests/commands/BinaryValuesCommandsTest.java src/test/java/redis/clients/jedis/tests/commands/HashesCommandsTest.java src/test/java/redis/clients/jedis/tests/commands/ScriptingCommandsTest.java src/test/java/redis/clients/jedis/tests/commands/SetCommandsTest.java
|
Applied to 2.8 and 2.9 respectively. Thx again @smadasu |
|
Fantastic! Glad I could help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have cleaned up all the Junit tests extending from Assert class. Please review