Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't auth if password is empty as REDIS doesn't support it #1809

Closed
wants to merge 1 commit into from

Conversation

marcosnils
Copy link
Contributor

Fixes #1808

Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcosnils
IMHO, throwing exception from constructor would be better approach for this case. Completely ignoring values sent by user doesn't seem to be a good idea.

PS: #1808 is closed.

@dnatic09
Copy link

dnatic09 commented May 8, 2018

My team has run into this problem before. I inherited a library with default configuration containing a password. I was unable to blank out the password by overriding the configuration. Instead of changing my configuration, I had to reconfigure my Redis servers. This would alleviate that issue.

@marcosnils
Copy link
Contributor Author

Just double checked and Redis actually allows you to start a server with an empty password and authenticate against it.

redis-server - <<< "requirepass \"\""
redis-cli
127.0.0.1:6379> auth ""
OK
127.0.0.1:6379> 

@marcosnils marcosnils closed this May 13, 2018
@marcosnils marcosnils deleted the avoid_empty_password branch May 13, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants