Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Could you please integrate a couple of missing functions? #264

Closed
wants to merge 2 commits into from

3 participants

@thonier

Hi,

Transaction.java seemed to be missing a couple of functions (zrevrangeByScoreWithScores with 2 prototypes). Since Client.java already has the corresponding implementation and "zrangeByScoreWithScores" is implemented, I assume this is a simple oversight.

Thanks a lot!
-Guillaume

@xetorthio
Owner

This is perfect. Would you mind adding to this pull request some tests?

@samhendley
Collaborator

Starting in jedis 2.2.0 Transaction now implements the following interfaces (which include those functions):

  • BasicRedisPipeline
  • BinaryRedisPipeline
  • RedisPipeline
  • MultiKeyBinaryRedisPipeline
  • MultiKeyCommandsPipeline
@samhendley samhendley closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 12 additions and 0 deletions.
  1. +12 −0 src/main/java/redis/clients/jedis/Transaction.java
View
12 src/main/java/redis/clients/jedis/Transaction.java
@@ -504,6 +504,18 @@ public Transaction(final Client client) {
client.zrevrangeWithScores(key, start, end);
return getResponse(BuilderFactory.TUPLE_ZSET);
}
+
+ public Response<Set<Tuple>> zrevrangeByScoreWithScores(String key, double min,
+ double max) {
+ client.zrevrangeByScoreWithScores(key, min, max);
+ return getResponse(BuilderFactory.TUPLE_ZSET);
+ }
+
+ public Response<Set<Tuple>> zrevrangeByScoreWithScores(String key, double min,
+ double max, int offset, int count) {
+ client.zrevrangeByScoreWithScores(key, min, max, offset, count);
+ return getResponse(BuilderFactory.TUPLE_ZSET);
+ }
public Response<Long> zrevrank(String key, String member) {
client.zrevrank(key, member);
Something went wrong with that request. Please try again.