Fix: warnings in ggs_autocorrelation #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem came from the use of 1:nLags which actually had several variables. What Xavier struggled with had no solution back then, but is now fixed in hadley/plyr#3 with the newly introduced function `here`.
|
Interesting finding! Congratulations for digging out that one. |
|
Thanks! I was amazed by the depth of thought that Hadley put in adding this feature :) It's really nifty, worth remembering for similar cases! |
Otherwise, an error was generated: now it's only a warning, we plot as far as we can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem came from the use of 1:nLags which actually had several variables.
What Xavier struggled with had no solution back then, but is now fixed in
hadley/plyr#3 with the newly introduced function
here.