Fix: Error in ggs_geweke from 0-var check in sde0f function #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I wrote and maintain a package that depends on
ggmcmc
(MixSIAR). In one of my updates, I encountered an error stemming fromggs_geweke
, which I traced tosde0f
.The error was surprising, because it occurred for a JAGS model with an informative prior, but NOT for the same model with the same data using an uninformative prior. My guess is the issue occurs for a parameter with nearly 0 variance. Your check for 0 variance in
sde0f
waslength(unique(x)) > 0
, but an alternative solution from Stack Overflow seems more robust in my case:When I make this change to
sde0f
I get no errors withggs_geweke
for either model.