Ensure test precondition setup.py should exist as a file #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As written the tests in test_tools assume the tests will be run in the root of the source and that a file named setup.py will exist. The Debian test runner installs the package into a subdirectory, and then runs the tests there. This adds a test setUp and tearDown to add (and remove) an empty setup.py if no setup.py file already exists
|
Hi there, thanks for the proposed minimal fix (much appreciated). As the current test for Can you tell me if the proposed change in this branch would resolve your issue? |
|
Okay, closing this in favour of a2eb0d9. |
|
Sorry I got distracted, yes your branch works. |
|
Thanks. |
gijzelaerr
pushed a commit
to kernsuite-debian/python-graphviz
that referenced
this pull request
Aug 20, 2018
… that there is a setup.py file doesn't apply. Forwarded: xflr6/graphviz#29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I building a Debian package for your package, and discovered a problem where one of the tests was failing. It was because the tests were written to assume that they'd be run in the root of the source tree, and not a partially installed copy
As written the tests in test_tools assume the tests will be run in the
root of the source and that a file named setup.py will exist.
The Debian test runner installs the package into a subdirectory,
and then runs the tests there, which lets the test code create a setup.py directory.
This adds a test setUp and tearDown to add (and remove) an empty
setup.py if no setup.py file already exists