-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.6 #40
Drop Python 3.6 #40
Conversation
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 3 3
Lines 215 215
Branches 58 58
=======================================
Hits 203 203
Misses 8 8
Partials 4 4 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed and thanks @jrbourbeau. Any idea why we're now regularly failing test_histogram_results_1d
in a number of active PRs (#38 also)? I'm happy to try look into this if nothing springs to mind.
Great, thanks for reviewing @dougiesquire! I've proposed a quick fix for |
Just included the quickfix from #41 here -- so CI is passing now. If we're comfortable dropping Python 3.6, then I think this PR should be good to go |
As
xhistogram
s dependencies, i.e.numpy
,dask
, andxarray
, have all dropped support for Python 3.6, it probably makes sense for us to drop support here too.