-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why spacing information is added as a new coordinate #124
Comments
Yes, that would be fine with me! This was a somewhat random choice early on. |
I think this spacing parameter should be a coordinate's attribute instead of an attribute of the dft itself. However, if spacing is an attribute of freq_x in A, it will be kept in B. It will be removed only if some operation is realized on the freq_x coordinate vector (which is almost never happening). |
I opened PR #126 to discuss about that |
solved in PR #126 |
When computing xrft.dft over dimension "x", a "freq_x_spacing" is added in the output as a new coordinates of dimension "1".
This new coord is disturbing since its not really a new dimension/coordinate.
Could it be better option to add this spacing information in output attributes instead of coordinates ?
The text was updated successfully, but these errors were encountered: