-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge edges #210
Merge edges #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Just some minor comments.
And a question: I think we had discussed at some point refactoring the output of H.duplicate_edges
once this was implemented. Or am I remembering incorrectly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Nicho, thanks.
Adding an "intersection" merge_rule could also make sense to me. For each set of merging nodes, set the attribute "color" to "red" if all merging nodes are red, otherwise discard the color attribute.
I like this idea and am working on it now! |
Thanks! |
Partially addressing #163.