Update xgi_data.py #254
Merged
Update xgi_data.py #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximelucas
reviewed
Dec 16, 2022
maximelucas
reviewed
Dec 16, 2022
…lean_file_path to _make_unix_file_path
maximelucas
reviewed
Dec 16, 2022
maximelucas
reviewed
Dec 16, 2022
maximelucas
reviewed
Dec 16, 2022
|
Nice thanks a lot Alice, looks good! |
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
maximelucas
reviewed
Dec 17, 2022
maximelucas
reviewed
Dec 17, 2022
nwlandry
reviewed
Dec 19, 2022
xgi/readwrite/xgi_data.py
Outdated
| elif path[-1]=='\\': | ||
| path = path.replace('\\', '/') | ||
|
|
||
| filepath = path + dataset + '.json' |
There was a problem hiding this comment.
Can you simplify this by doing something with os.path? Like os.path.join() or something like that?
There was a problem hiding this comment.
good catch! just did
There was a problem hiding this comment.
I think you're missing the ".json" now if I'm not mistaken.
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
|
Pending changing "jason" to "json", I would say that this is good to go! I'll add an issue for potentially changing |
nwlandry
approved these changes
Dec 19, 2022
maximelucas
approved these changes
Dec 20, 2022
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*added a
download_xgi_datafunction that download data from gitlab to a local directory*changed
load_xgi_dataso that it can now load data from online sources and local files. For loading data from online sources, it is now using the index.json and the data stored on gitlab.*some refactoring so that
load_xgi_dataanddownload_xgi_datacan use the same code snippets