-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update xgi_data.py #254
Update xgi_data.py #254
Conversation
…lean_file_path to _make_unix_file_path
Nice thanks a lot Alice, looks good! |
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
xgi/readwrite/xgi_data.py
Outdated
elif path[-1]=='\\': | ||
path = path.replace('\\', '/') | ||
|
||
filepath = path + dataset + '.json' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you simplify this by doing something with os.path
? Like os.path.join()
or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! just did
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're missing the ".json" now if I'm not mistaken.
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Pending changing "jason" to "json", I would say that this is good to go! I'll add an issue for potentially changing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! See comments in the main conversation! You should be able to squash and merge? Let me know if not.
Nice, thanks! |
*added a
download_xgi_data
function that download data from gitlab to a local directory*changed
load_xgi_data
so that it can now load data from online sources and local files. For loading data from online sources, it is now using the index.json and the data stored on gitlab.*some refactoring so that
load_xgi_data
anddownload_xgi_data
can use the same code snippets