-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New drawing style #369
New drawing style #369
Conversation
drawing function
run black on draw.py
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
+ Coverage 90.58% 90.72% +0.13%
==========================================
Files 41 41
Lines 3060 3105 +45
==========================================
+ Hits 2772 2817 +45
Misses 288 288
☔ View full report in Codecov by Sentry. |
Thanks for this contribution, @thomasrobiglio! Looks great 🤩. My only question is, Is there a reason for using PolyCollection instead of scatter for the nodes? Also maybe you can open an issue on allowing 3d axes in |
Thank you for the comment @nwlandry! Actually I'm not sure I understand you question - I use About opening the issues we can for sure do that. I'm a bit afraid that using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! The comments that I was suggesting don't seem feasible.
It looks very pretty @thomasrobiglio thanks :) I even showed it to my class on Friday hehe. |
Thank you so much @thomasrobiglio ! |
Related to #358, allows for new drawing style where hyperedges/simplices of different orders are draw on different layers of a 3-dimensional plot.