-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return mappable to allow colorbar #441
Conversation
Following what I described in #437 , I have rewritten In particular:
This implementation has the following advantages:
Question before I fix tests: are you okay with this? If we agree on this, we could later look into |
Okay some initial thoughts:
Other issues that are potentially related to this are #174, #272, #280, and #410. |
Sure we could do that. I just wasn't sure if it would be a common use case?
Yes, I thought we might put some of the new code back into simplified versions of those. It was easier to start from scratch at first to know what I really needed. I would probably do that in another PR where we also deal with drawing hyperedges, because if I change
You're right, I'm clipping the node size values with min/max. I thought that's what we were trying to do before, but we were trying to rescale them between min/max indeed. Rescaling is a better idea I agree. I wonder if we want to do it by default or not though. If you compare two hypergraphs, you can see relative difference between nodes but not absolute ones. Should we let the user deal with this, or just have it as an option? Same with
Thanks I'll look into them. |
…color. warning: removed when cmap is ignoed because single color
Update:
Only thing left to decide:
Also: the tests fail on Github saying |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
==========================================
- Coverage 91.84% 91.82% -0.03%
==========================================
Files 60 60
Lines 4255 4280 +25
==========================================
+ Hits 3908 3930 +22
- Misses 347 350 +3
☔ View full report in Codecov by Sentry. |
…fter creating this branch?
…ng_sizes' argument. test: added for new function.
Okay Nich I think I did everything we discussed:
I think it's ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Max! Thanks so much for this PR. My only small comment is that perhaps you should be consistent with the documentation on _draw_arg_to_arr
. I think a more accurate descriptor would be that it makes args pyplot compliant instead of converting everything to an array?
Great, changed it. Thanks so much for reviewing this big PR Nich! |
Trying to solve #437. So far, only tests.