Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sphinx errors #487

Merged
merged 8 commits into from
Nov 2, 2023
Merged

Fixed sphinx errors #487

merged 8 commits into from
Nov 2, 2023

Conversation

nwlandry
Copy link
Collaborator

I fixed a good majority of sphinx errors. I also changed the function names in the convert module to be consistent.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2eea477) 92.00% compared to head (638e09c) 91.89%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
- Coverage   92.00%   91.89%   -0.12%     
==========================================
  Files          60       60              
  Lines        4428     4441      +13     
==========================================
+ Hits         4074     4081       +7     
- Misses        354      360       +6     
Files Coverage Δ
xgi/convert/graph.py 100.00% <100.00%> (ø)
xgi/core/dihypergraph.py 98.12% <100.00%> (ø)
xgi/core/diviews.py 83.60% <ø> (ø)
xgi/core/hypergraph.py 93.54% <100.00%> (ø)
xgi/core/simplicialcomplex.py 85.66% <100.00%> (ø)
xgi/core/views.py 94.11% <ø> (ø)
xgi/drawing/draw.py 76.90% <ø> (-1.04%) ⬇️
xgi/drawing/layout.py 99.18% <100.00%> (ø)
xgi/generators/randomizing.py 91.80% <ø> (ø)
xgi/stats/__init__.py 85.46% <ø> (ø)
... and 5 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximelucas
Copy link
Collaborator

Thanks! And good idea for the renaming.

I noticed some links still aren't working in the online docs, page About and Index (the blue links):

Screenshot 2023-10-30 at 08 54 05

And the funding link does not seem to be working either "HNDS-I: Using Hypergraphs to Study Spreading Processes in Complex Social Networks.".

@nwlandry
Copy link
Collaborator Author

Thanks for the suggestions!! I fixed all the issues you raised and also removed any mention of the old tutorials location.

@maximelucas
Copy link
Collaborator

Looks good! Better to leave #485 for another PR right?

@nwlandry nwlandry mentioned this pull request Nov 2, 2023
9 tasks
@nwlandry
Copy link
Collaborator Author

nwlandry commented Nov 2, 2023

I think I might have fixed a good number of the broken links, but it needs a double-check. We can open a dedicated PR if necessary.

@nwlandry nwlandry merged commit 1debfd5 into main Nov 2, 2023
22 of 23 checks passed
@nwlandry nwlandry deleted the fix-docs branch November 2, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants