Skip to content

Merge pull request #22 from vcoppe/lcs #283

Merge pull request #22 from vcoppe/lcs

Merge pull request #22 from vcoppe/lcs #283

Triggered via push June 9, 2023 09:21
Status Success
Total duration 2m 41s
Artifacts

qa.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

6 warnings
the loop variable `i` is only used to index `table`: ddo/examples/lcs/dp.rs#L31
warning: the loop variable `i` is only used to index `table` --> ddo/examples/lcs/dp.rs:31:18 | 31 | for i in 0..=self.a.len() { | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator | 31 | for <item> in table.iter_mut().take(self.a.len() + 1) { | ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
the loop variable `i` is used to index `position`: ddo/examples/lcs/model.rs#L186
warning: the loop variable `i` is used to index `position` --> ddo/examples/lcs/model.rs:186:22 | 186 | for i in 0..self.pb.n_strings { | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator and enumerate() | 186 | for (i, <item>) in position.iter_mut().enumerate().take(self.pb.n_strings) { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
the loop variable `str` is used to index `position`: ddo/examples/lcs/model.rs#L115
warning: the loop variable `str` is used to index `position` --> ddo/examples/lcs/model.rs:115:24 | 115 | for str in 0..self.n_strings { | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator and enumerate() | 115 | for (str, <item>) in position.iter_mut().enumerate().take(self.n_strings) { | ~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
this function has too many arguments (8/7): ddo/src/implementation/solver/parallel.rs#L320
warning: this function has too many arguments (8/7) --> ddo/src/implementation/solver/parallel.rs:320:5 | 320 | / pub fn custom( 321 | | problem: &'a (dyn Problem<State = State> + Send + Sync), 322 | | relaxation: &'a (dyn Relaxation<State = State> + Send + Sync), 323 | | ranking: &'a (dyn StateRanking<State = State> + Send + Sync), ... | 328 | | nb_threads: usize, 329 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
this function has too many arguments (8/7): ddo/src/implementation/solver/parallel.rs#L320
warning: this function has too many arguments (8/7) --> ddo/src/implementation/solver/parallel.rs:320:5 | 320 | / pub fn custom( 321 | | problem: &'a (dyn Problem<State = State> + Send + Sync), 322 | | relaxation: &'a (dyn Relaxation<State = State> + Send + Sync), 323 | | ranking: &'a (dyn StateRanking<State = State> + Send + Sync), ... | 328 | | nb_threads: usize, 329 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
clippy_check
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.