Merge pull request #28 from vcoppe/alp #289
Annotations
25 warnings
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
ddo/examples/talentsched/io_utils.rs#L75
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> ddo/examples/talentsched/io_utils.rs:75:13
|
75 | / match data.next() {
76 | | Some(val) => {
77 | | nb_actors = val.parse()?;
78 | | i += 1;
79 | | },
80 | | None => (),
81 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try this
|
75 ~ if let Some(val) = data.next() {
76 + nb_actors = val.parse()?;
77 + i += 1;
78 + }
|
|
the loop variable `j` is used to index `actors`:
ddo/examples/talentsched/model.rs#L47
warning: the loop variable `j` is used to index `actors`
--> ddo/examples/talentsched/model.rs:47:22
|
47 | for j in 0..instance.nb_scenes {
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator and enumerate()
|
47 | for (j, <item>) in actors.iter_mut().enumerate().take(instance.nb_scenes) {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
the loop variable `i` is only used to index `table`:
ddo/examples/lcs/dp.rs#L31
warning: the loop variable `i` is only used to index `table`
--> ddo/examples/lcs/dp.rs:31:18
|
31 | for i in 0..=self.a.len() {
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
|
31 | for <item> in table.iter_mut().take(self.a.len() + 1) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
the loop variable `i` is used to index `position`:
ddo/examples/lcs/model.rs#L186
warning: the loop variable `i` is used to index `position`
--> ddo/examples/lcs/model.rs:186:22
|
186 | for i in 0..self.pb.n_strings {
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator and enumerate()
|
186 | for (i, <item>) in position.iter_mut().enumerate().take(self.pb.n_strings) {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
the loop variable `str` is used to index `position`:
ddo/examples/lcs/model.rs#L115
warning: the loop variable `str` is used to index `position`
--> ddo/examples/lcs/model.rs:115:24
|
115 | for str in 0..self.n_strings {
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator and enumerate()
|
115 | for (str, <item>) in position.iter_mut().enumerate().take(self.n_strings) {
| ~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
the loop variable `i` is only used to index `lengths`:
ddo/examples/srflp/io_utils.rs#L88
warning: the loop variable `i` is only used to index `lengths`
--> ddo/examples/srflp/io_utils.rs:88:18
|
88 | for i in 0..nb_departments {
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
|
88 | for <item> in lengths.iter_mut().take(nb_departments) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
the loop variable `i` is used to index `lengths`:
ddo/examples/srflp/relax.rs#L177
warning: the loop variable `i` is used to index `lengths`
--> ddo/examples/srflp/relax.rs:177:18
|
177 | for i in 0..(complete_arrangement-1) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator and enumerate()
|
177 | for (i, <item>) in lengths.iter().enumerate().take((complete_arrangement-1)) {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
using `clone` on type `Option<Set64>` which implements the `Copy` trait:
ddo/examples/srflp/model.rs#L102
warning: using `clone` on type `Option<Set64>` which implements the `Copy` trait
--> ddo/examples/srflp/model.rs:102:26
|
102 | let mut maybes = state.maybe_place.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `state.maybe_place`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `Set64` which implements the `Copy` trait:
ddo/examples/srflp/model.rs#L99
warning: using `clone` on type `Set64` which implements the `Copy` trait
--> ddo/examples/srflp/model.rs:99:29
|
99 | let mut remaining = state.must_place.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `state.must_place`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
methods called `from_*` usually take no `self`:
ddo/examples/alp/model.rs#L101
warning: methods called `from_*` usually take no `self`
--> ddo/examples/alp/model.rs:101:26
|
101 | pub fn from_decision(&self, value: isize) -> AlpDecision {
| ^^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
= note: `#[warn(clippy::wrong_self_convention)]` on by default
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
ddo/examples/alp/model.rs#L85
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> ddo/examples/alp/model.rs:85:42
|
85 | pub fn get_arrival_time(&self, info: &Vec<RunwayState>, aircraft: usize, runway: usize) -> isize {
| ^^^^^^^^^^^^^^^^^ help: change this to: `&[RunwayState]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
the loop variable `j` is used to index `min_separation_to`:
ddo/examples/alp/model.rs#L73
warning: the loop variable `j` is used to index `min_separation_to`
--> ddo/examples/alp/model.rs:73:22
|
73 | for j in 0..instance.nb_classes {
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator and enumerate()
|
73 | for (j, <item>) in min_separation_to.iter_mut().enumerate().take(instance.nb_classes) {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
this function has too many arguments (8/7):
ddo/src/implementation/solver/parallel.rs#L320
warning: this function has too many arguments (8/7)
--> ddo/src/implementation/solver/parallel.rs:320:5
|
320 | / pub fn custom(
321 | | problem: &'a (dyn Problem<State = State> + Send + Sync),
322 | | relaxation: &'a (dyn Relaxation<State = State> + Send + Sync),
323 | | ranking: &'a (dyn StateRanking<State = State> + Send + Sync),
... |
328 | | nb_threads: usize,
329 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
casting to the same type is unnecessary (`usize` -> `usize`):
ddo/examples/tsptw/heuristics.rs#L50
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> ddo/examples/tsptw/heuristics.rs:50:25
|
50 | self.nb_vars * (state.depth as usize + 1) * self.factor
| ^^^^^^^^^^^^^^^^^^^^ help: try: `state.depth`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
using `clone` on type `Set256` which implements the `Copy` trait:
ddo/examples/tsptw/relax.rs#L153
warning: using `clone` on type `Set256` which implements the `Copy` trait
--> ddo/examples/tsptw/relax.rs:153:25
|
153 | let mut maybe = self.all_maybe.clone(); // three lines: faster because it is in-place
| ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.all_maybe`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `Set256` which implements the `Copy` trait:
ddo/examples/tsptw/relax.rs#L150
warning: using `clone` on type `Set256` which implements the `Copy` trait
--> ddo/examples/tsptw/relax.rs:150:9
|
150 | self.all_agree.clone()
| ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.all_agree`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `Set256` which implements the `Copy` trait:
ddo/examples/tsptw/relax.rs#L135
warning: using `clone` on type `Set256` which implements the `Copy` trait
--> ddo/examples/tsptw/relax.rs:135:27
|
135 | Position::Virtual(self.position.clone())
| ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
casting to the same type is unnecessary (`usize` -> `usize`):
ddo/examples/tsptw/model.rs#L212
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> ddo/examples/tsptw/model.rs:212:66
|
212 | .map(|i| self.instance.distances[i as usize][j as usize])
| ^^^^^^^^^^ help: try: `j`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`usize` -> `usize`):
ddo/examples/tsptw/model.rs#L212
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> ddo/examples/tsptw/model.rs:212:54
|
212 | .map(|i| self.instance.distances[i as usize][j as usize])
| ^^^^^^^^^^ help: try: `i`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`usize` -> `usize`):
ddo/examples/tsptw/model.rs#L202
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> ddo/examples/tsptw/model.rs:202:66
|
202 | .map(|i| self.instance.distances[i as usize][j as usize])
| ^^^^^^^^^^ help: try: `j`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`usize` -> `usize`):
ddo/examples/tsptw/model.rs#L202
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> ddo/examples/tsptw/model.rs:202:54
|
202 | .map(|i| self.instance.distances[i as usize][j as usize])
| ^^^^^^^^^^ help: try: `i`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
using `clone` on type `Option<Set256>` which implements the `Copy` trait:
ddo/examples/tsptw/model.rs#L100
warning: using `clone` on type `Option<Set256>` which implements the `Copy` trait
--> ddo/examples/tsptw/model.rs:100:26
|
100 | let mut maybes = state.maybe_visit.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `state.maybe_visit`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `Set256` which implements the `Copy` trait:
ddo/examples/tsptw/model.rs#L97
warning: using `clone` on type `Set256` which implements the `Copy` trait
--> ddo/examples/tsptw/model.rs:97:29
|
97 | let mut remaining = state.must_visit.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `state.must_visit`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
this function has too many arguments (8/7):
ddo/src/implementation/solver/parallel.rs#L320
warning: this function has too many arguments (8/7)
--> ddo/src/implementation/solver/parallel.rs:320:5
|
320 | / pub fn custom(
321 | | problem: &'a (dyn Problem<State = State> + Send + Sync),
322 | | relaxation: &'a (dyn Relaxation<State = State> + Send + Sync),
323 | | ranking: &'a (dyn StateRanking<State = State> + Send + Sync),
... |
328 | | nb_threads: usize,
329 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
clippy_check
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
|