Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added App Notification examples to Other tab #357

Merged
merged 5 commits into from
Feb 19, 2020
Merged

Conversation

petradish
Copy link
Contributor

This PR addresses part of issue #23
Created "App Notifications" tab under Other tab to showcase:

  • App Update Banner
  • Idle Service
    I thought these two tiles made sense as a grouping of notifications from the server.

Will submit separate PRs for Exception Handler, Preferences, and getUser

@petradish petradish linked an issue Feb 14, 2020 that may be closed by this pull request
@amcclain
Copy link
Member

I think this looks great and will merge - made some small tweaks to the language.

We can continue to re-org this Other tab as needed while adding more examples like this.

@amcclain amcclain merged commit f2293d2 into develop Feb 19, 2020
@amcclain amcclain deleted the otherTabGoodies branch February 19, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional "Other" tab ideas
2 participants