Refactor repetitive attachment code and add tests. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ains. Add some simple tests.
jlinnosa
force-pushed
the
refactor-attach
branch
from
c6f5cd5
to
bc4561c
Compare
|
Thanks! LGTM. And about:
Yes, is my first go package, maybe a good refactor to a v3 should need it. If you have some ideas, fill an issue listing the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminated some repetitive code and added simple tests.
We should use common function signatures for all attachment related functions but this would be a breaking change and has to wait for the next major revision...