Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the requirements to use PyPDF2 #181

Closed
zkanda opened this issue Apr 15, 2014 · 16 comments
Closed

Change the requirements to use PyPDF2 #181

zkanda opened this issue Apr 15, 2014 · 16 comments

Comments

@zkanda
Copy link

zkanda commented Apr 15, 2014

Newer version of PyPDF...

@darylyu
Copy link
Contributor

darylyu commented Apr 15, 2014

It's already using PyPDF2.

@darylyu
Copy link
Contributor

darylyu commented Apr 15, 2014

Unless you mean something else...

@lingthio
Copy link
Contributor

When I perform pip install xhtml2pdf==0.0.5 I get the following error:

Could not find any downloads that satisfy the requirement pyPdf

@zkanda
Copy link
Author

zkanda commented Apr 16, 2014

Sorry I didn't dig in the source code, but can you guys update the pypi package with this new version? Or probably the right question: When is the next version? :)

@darylyu
Copy link
Contributor

darylyu commented Apr 16, 2014

I don't have rights to the pypi package. You'll have to talk to @chrisglass about that.

For the mean time, you can just add this to requirements.txt:

-e git+https://github.com/chrisglass/xhtml2pdf@a94b95b057#egg=xhtml2pdf

Or run this on your shell:

pip install -e git+https://github.com/chrisglass/xhtml2pdf@a94b95b057#egg=xhtml2pdf

a9ab95b057 is just an example. You can swap it out for a newer change set if you want.

@stephenmcd
Copy link

I think libraries depending on xhtml2pdf that are currently failing to install due to this don't have the luxury of specifying repo dependencies in their own setup.py scripts unfortunately.

Other than temporarily updating our own documentation to say "currently you need to pass pip these handful of horrendous options because computers are terrible", our only option is to sit here and wait with broken install workflows until xhtml2pdf gets a new pypi release.

@stephenmcd
Copy link

@darylyu in this thread @chrisglass said he'd give you pypi rights:

#147 (comment)

Sorry to ask, but can you guys make this happen?

@chrisglass
Copy link
Contributor

@darylyu let me know what your pypi username is and I'll give your
maintainership.

On Wed, Apr 23, 2014 at 6:18 AM, Stephen McDonald
notifications@github.comwrote:

@darylyu https://github.com/darylyu in this thread @chrisglasshttps://github.com/chrisglasssaid he'd give you pypi rights:

#147 (comment)#147 (comment)

Sorry to ask, but can you guys make this happen?


Reply to this email directly or view it on GitHubhttps://github.com//issues/181#issuecomment-41120683
.

@darylyu
Copy link
Contributor

darylyu commented Apr 23, 2014

@chrisglass I'm dyu on pypi.

@chrisglass
Copy link
Contributor

@darylyu done - you should have maintainership of the package on pypi!

On Wed, Apr 23, 2014 at 8:34 AM, D. Yu notifications@github.com wrote:

@chrisglass https://github.com/chrisglass I'm dyu on pypi.


Reply to this email directly or view it on GitHubhttps://github.com//issues/181#issuecomment-41126310
.

@darylyu
Copy link
Contributor

darylyu commented Apr 23, 2014

OMG. What did I get myself into? 0_o

Thanks!

@chrisglass
Copy link
Contributor

Hehe don't worry, you can't do worse than me anyway :)

On Wed, Apr 23, 2014 at 8:47 AM, D. Yu notifications@github.com wrote:

OMG. What did I get myself into? 0_o

Thanks!


Reply to this email directly or view it on GitHubhttps://github.com//issues/181#issuecomment-41126872
.

@stephenmcd
Copy link

Thanks a million guys.

@zkanda zkanda closed this as completed Apr 25, 2014
@darylyu
Copy link
Contributor

darylyu commented Apr 27, 2014

I just released 0.0.6 on pypi.

Sorry this took a while.

The usual excuses: work. life, sucky WiFi while on vacation...

@stephenmcd
Copy link

This resolved the install issues our package was having - thanks so much, no apology necessary :-)

@chrisglass
Copy link
Contributor

Great job Daryl!

Thanks a lot for picking up the ball.

On Sun, Apr 27, 2014 at 7:15 PM, D. Yu notifications@github.com wrote:

I just released 0.0.6 on pypi.

Sorry this took a while.

The usual excuses: work. life, sucky WiFi while on vacation...


Reply to this email directly or view it on GitHubhttps://github.com//issues/181#issuecomment-41500826
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants